tree 17b8aacfcdab3fa1f361e40557fcff6f581a194e
parent b33cc90019824a8a157f2d5a042912a4b7d67391
author Eylon Krause <eylon1909@gmail.com> 1783348391 +0300
committer Eylon Krause <eylon1909@gmail.com> 1783348391 +0300

port-name-suffix: handle `ref` direction and all-underscore names

PortNameSuffixRule crashed the linter on two valid inputs:

- A `ref` port direction: IsSuffixCorrect did suffixes.at(direction) on a map
  keyed only by input/output/inout, so a `ref` port (allowed by the grammar)
  threw std::out_of_range, uncaught, aborting the linter. Look the direction
  up with find() and treat an unknown direction as correct (no violation),
  matching Violation() which already ignores non-input/output/inout.

- An all-underscore name (e.g. "_"): absl::StrSplit with SkipEmpty yields an
  empty parts list, and the size()<2 branch did not return, so name_parts.back()
  dereferenced an empty vector (UB). Return after reporting the violation; this
  also drops a redundant duplicate Violation for no-underscore names.

Adds regression tests: a `ref` port is accepted, and an all-underscore port
reports a single suffix violation instead of crashing.

Signed-off-by: Eylon Krause <eylon1909@gmail.com>