Merge pull request #1559 from chipsalliance/propagate-failures-in-releases-setup

Propagate failures in releases setup + use Bazel 4.0.0

.github/bin/build-and-test.sh

diff --git a/.github/bin/build-and-test.sh b/.github/bin/build-and-test.sh
index f0910c7..f059ac7 100755
--- a/.github/bin/build-and-test.sh
+++ b/.github/bin/build-and-test.sh
@@ -94,7 +94,6 @@
     bazel coverage \
           --combined_report=lcov \
           --coverage_report_generator=@bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:Main \
-          --java_runtime_version=remotejdk_11 \
           ${CHOSEN_TARGETS}
     # output will be in bazel-out/_coverage/_coverage_report.dat
     ;;

.github/bin/github-releases-setup.sh

diff --git a/.github/bin/github-releases-setup.sh b/.github/bin/github-releases-setup.sh
index 9490ab7..3cffa29 100755
--- a/.github/bin/github-releases-setup.sh
+++ b/.github/bin/github-releases-setup.sh
@@ -17,8 +17,10 @@
 # ---------------
 # Generate the GitHub Releases to deploy
 
+set -ex
+
 RELEASE_DIR=${1:-/tmp/releases}
-rm -rf $RELEASE_DIR
+rm -rf "$RELEASE_DIR/*"
 
 GIT_VERSION=${GIT_VERSION:-$(git rev-parse --short "$GITHUB_SHA")}
 
@@ -36,7 +38,7 @@
 for BIN in $PREFIX_BIN/*; do
     ls -l $BIN
     file $BIN
-    ldd $BIN
+    ldd $BIN || true # ignore the potential 'not a dynamic executable' errors for non-binaries
 done
 
 # Documentation

.github/settings.sh

diff --git a/.github/settings.sh b/.github/settings.sh
index 66b92a4..91028b0 100644
--- a/.github/settings.sh
+++ b/.github/settings.sh
@@ -32,7 +32,7 @@
 export BAZEL_OPTS="-c opt --show_progress_rate_limit=10.0"
 
 # Used to fetch the BAZEL version where needed.
-export BAZEL_VERSION=5.3.2
+export BAZEL_VERSION=4.0.0
 
 # TODO(b/171989992): revert to using release version after upgrading system
 #   libraries/image (need: GLIBCXX_3.4.26, CXXABI_1.3.11, GLIBC_2.29).

.github/workflows/verible-ci.yml

diff --git a/.github/workflows/verible-ci.yml b/.github/workflows/verible-ci.yml
index 045a116..a67f348 100644
--- a/.github/workflows/verible-ci.yml
+++ b/.github/workflows/verible-ci.yml
@@ -15,6 +15,7 @@
   BOT_USER: "Deployment Bot"
   BOT_EMAIL: "verible-dev@googlegroups.com"
   GHA_MACHINE_TYPE: "n2-standard-8"
+  DEBIAN_FRONTEND: "noninteractive"
 
 jobs:
 
@@ -154,7 +155,7 @@
       run: |
         set -x
         apt -qqy update
-        apt -qq -y install clang-10 build-essential wget git python3 python-is-python3 gcc-10 g++-10
+        apt -qq -y install clang-10 build-essential wget git python3 python-is-python3 gcc-10 g++-10 default-jdk
         source ./.github/settings.sh
         ./.github/bin/set-compiler.sh 10
         ./.github/bin/install-bazel.sh